feat(deployment): Regular DB maintenance #401
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorneanu
commented
Nov 25, 2024
| # Just for testing purposes | ||
| repository: db-maintenance | ||
| tag: "local" | ||
| pullPolicy: "never" |
There was a problem hiding this comment.
Need to discuss schedule interval.
There was a problem hiding this comment.
Thats fine from my perspective once a minute is a bit often though....
Maybe you rather say once at 1 : 30 at night per default:
schedule: "30 1 * * *"
Comment on lines
27
to
31
| TRUNCATE TABLE IssueMatch; | ||
| TRUNCATE TABLE Evidence; | ||
| TRUNCATE TABLE ComponentInstance; | ||
| TRUNCATE TABLE IssueVariant; | ||
| TRUNCATE TABLE ComponentVersion; |
There was a problem hiding this comment.
Suggested change
| TRUNCATE TABLE IssueMatch; | |
| TRUNCATE TABLE Evidence; | |
| TRUNCATE TABLE ComponentInstance; | |
| TRUNCATE TABLE IssueVariant; | |
| TRUNCATE TABLE ComponentVersion; | |
| TRUNCATE TABLE IssueMatch; | |
| TRUNCATE TABLE Evidence; | |
| TRUNCATE TABLE ComponentInstance; | |
| TRUNCATE TABLE IssueVariant; | |
| TRUNCATE TABLE ComponentVersion; |
Not sure about these ones.
drochow
approved these changes
Nov 28, 2024
| # Just for testing purposes | ||
| repository: db-maintenance | ||
| tag: "local" | ||
| pullPolicy: "never" |
There was a problem hiding this comment.
Thats fine from my perspective once a minute is a bit often though....
Maybe you rather say once at 1 : 30 at night per default:
schedule: "30 1 * * *"
|
I think this PR should rather be in https://github.wdf.sap.corp/cc/heureka. This functionality is only SAP related. I'll close this one and create new one in GH enterprise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We should clean-up the Heureka Db regularly in order to be able to scan periodically.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?
Checklist